Messages in this thread | | | From | Fabrizio Castro <> | Subject | RE: [PATCH/RFT] pinctrl: renesas: rzv2m: Handle non-unique subnode names | Date | Tue, 4 Jul 2023 15:48:19 +0000 |
| |
Hi Geert,
Thank you for your patch!
> From: Geert Uytterhoeven <geert+renesas@glider.be> > Subject: [PATCH/RFT] pinctrl: renesas: rzv2m: Handle non-unique subnode > names > > The eMMC and SDHI pin control configuration nodes in DT have subnodes > with the same names ("data" and "ctrl"). As the RZ/V2M pin control > driver considers only the names of the subnodes, this leads to > conflicts: > > pinctrl-rzv2m b6250000.pinctrl: pin P8_2 already requested by > 85000000.mmc; cannot claim for 85020000.mmc > pinctrl-rzv2m b6250000.pinctrl: pin-130 (85020000.mmc) status -22 > renesas_sdhi_internal_dmac 85020000.mmc: Error applying setting, reverse > things back > > Fix this by constructing unique names from the node names of both the > pin control configuration node and its child node, where appropriate. > > Reported by: Fabrizio Castro <fabrizio.castro.jz@renesas.com> > Fixes: 92a9b825257614af ("pinctrl: renesas: Add RZ/V2M pin and gpio > controller driver") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Tested-by: Fabrizio Castro <fabrizio.castro.jz@renesas.com>
| |