Messages in this thread | | | Date | Tue, 4 Jul 2023 10:29:29 -0300 | Subject | Re: [PATCH] btf, scripts: rust: drop is_rust_module.sh | From | Martin Rodriguez Reboredo <> |
| |
On 7/4/23 02:21, Andrea Righi wrote: > With commit c1177979af9c ("btf, scripts: Exclude Rust CUs with pahole") > we are now able to use pahole directly to identify Rust compilation > units (CUs) and exclude them from generating BTF debugging information > (when DEBUG_INFO_BTF is enabled). > > And if pahole doesn't support the --lang-exclude flag, we can't enable > both RUST and DEBUG_INFO_BTF at the same time. > > So, in any case, the script is_rust_module.sh is just redundant and we > can drop it. > > NOTE: we may also be able to drop the "Rust loadable module" mark > inside Rust modules, but it seems safer to keep it for now to make sure > we are not breaking any external tool that may potentially rely on it.
Keep it, I think it can be useful with tooling like kmod.
> > Signed-off-by: Andrea Righi <andrea.righi@canonical.com> > --- > [...]
Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com>
| |