Messages in this thread | | | Date | Tue, 4 Jul 2023 08:05:21 +0200 | Subject | Re: [PATCH] pstore/ram: Add support for dynamically allocated ramoops memory regions | From | Krzysztof Kozlowski <> |
| |
On 22/06/2023 02:52, Isaac J. Manjarres wrote: > From: "Isaac J. Manjarres" <isaacm@codeaurora.org> > > The reserved memory region for ramoops is assumed to be at a fixed > and known location when read from the devicetree. This is not desirable > in environments where it is preferred for the region to be dynamically > allocated early during boot (i.e. the memory region is defined with > the "alloc-ranges" property instead of the "reg" property). > > If the location of the ramoops region is not fixed via the "reg" > devicetree property, the call to platform_get_resource() will fail > because resources of type IORESOURCE_MEM must be described with the > "reg" property. > > Since ramoops regions are part of the reserved-memory devicetree > node, they exist in the reserved_mem array. This means that the > of_reserved_mem_lookup() function can be used to retrieve the > reserved_mem structure for the ramoops region, and that structure > contains the base and size of the region, even if it has been > dynamically allocated. > > Thus invoke of_reserved_mem_lookup() in case the call to > platform_get_resource() fails in order to support dynamically > allocated ramoops memory regions.
You missed change to Devicetree binding, so the reg is still required for all DT-based platforms. For such, this patch is just half-baked.
You also did not CC DT maintainers, which would be nice considering some improper advises for minidump like here: https://lore.kernel.org/lkml/e25723bf-be85-b458-a84c-1a45392683bb@gmail.com/
DT is not for some dynamically allocated properties or dynamic system configuration. You don't need DT for that. Therefore if you remove the reg, I question the entire point of this binding.
See also: https://lore.kernel.org/lkml/CAL_JsqJ_TTnGjjB2d8_FKHpWBRG5GHLoWnabCKjsdeZ4QFdNEg@mail.gmail.com/
https://lore.kernel.org/lkml/20230202235916.GA2931100-robh@kernel.org/
Best regards, Krzysztof
| |