lkml.org 
[lkml]   [2023]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5,07/11] media: mediatek: vcodec: separate struct 'mtk_vcodec_ctx'
From
Il 04/07/23 13:13, Yunfei Dong ha scritto:
> Adding different context struct for encoder and decoder and removing
> struct 'mtk_vcodec_ctx'.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
> Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
> ---
> .../mediatek/vcodec/mtk_vcodec_com_drv.h | 76 +++++

Only one remark. "com" may mean "communication" or "common", but if you rename
this to `mtk_vcodec_cmn_drv.h`, then "cmn" can only mean "common", which would
increase the chances to immediately understand what the header is about.

Unless, of course, anyone else has strong opinions against. Besides....

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>

\
 
 \ /
  Last update: 2023-07-04 14:14    [W:0.061 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site