Messages in this thread | | | Date | Tue, 4 Jul 2023 12:54:55 +0100 | From | Mark Brown <> | Subject | Re: [PATCH] PCI: dwc: Provide deinit callback for i.MX |
| |
On Tue, Jul 04, 2023 at 08:50:15AM -0300, Fabio Estevam wrote:
> I recall seeing this regulator warning before: > f81f095e8771 ("PCI: imx6: Allow to probe when dw_pcie_wait_for_link() fails")
> I think the real issue is why does the probe fail when the link is not up?
Well, they're both issues - if someone unloads or unbinds the driver we can still trigger this, even if the probe succeeded.
> It should not fail to probe. At least, this was the original intention > with Rob's commit:
> 886a9c134755 ("PCI: dwc: Move link handling into common code")
> + return 0; > > err_remove_edma: > dw_pcie_edma_remove(pci);
I have no idea about doing this, all the PCI on the board that I care about seems to work fine (and worked fine even with the failure, I'm not sure this is being generated by a link that's in use). [unhandled content-type:application/pgp-signature] | |