Messages in this thread | ![/](/images/icornerl.gif) | | From | Linus Walleij <> | Date | Tue, 4 Jul 2023 11:08:41 +0200 | Subject | Re: [PATCH v1 1/1] usb: musb: Use read_poll_timeout() |
| |
On Mon, Jul 3, 2023 at 2:19 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Use read_poll_timeout() instead of open coding it. > In the same time, fix the typo in the error message. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> (...) > + ret = read_poll_timeout(gpiod_get_value, reg, !reg, 1000, 100000, true, > + glue->intpin);
Wow that's really cool. I had no idea that you could use read_poll_timeout() together with gpiod_get_value() like this!
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| ![\](/images/icornerr.gif) |