Messages in this thread | | | From | Koba Ko <> | Date | Tue, 4 Jul 2023 16:59:12 +0800 | Subject | Re: [v2/v3] EDAC/i10nm: shift exponent is negative |
| |
On Tue, Jul 4, 2023 at 4:50 PM Markus Elfring <Markus.Elfring@web.de> wrote: > > > @Markus and all, > > please review it, thanks > > > > Subject: [PATCH][V3] EDAC/i10nm: Fix an inappropriate shift exponen > > * Combined prefixes would be nicer. Do you mean, [PATCH V3]? > * Please avoid a typo here.
=> exponent
> > > when get rows, cols and ranks, A special value combination could not > > be handled so far. > > It seems that you stumble still on wording difficulties.
remove the previous sentence, A special value combination could not be handled so far.
> > > Fixes: 4ec656bdf43a13 (EDAC, skx_edac: Add EDAC driver for Skylake) > > You overlooked somehow to use double quotes here.
must be Fixes: 4ec656bdf43a13 ("EDAC, skx_edac: Add EDAC driver for Skylake")
> Please provide the next version of a proper patch. > > Regards, > Markus
| |