Messages in this thread | ![/](/images/icornerl.gif) | | From | Jani Nikula <> | Subject | Re: [PATCH] drm/i915/pmu: Use local64_try_cmpxchg in i915_pmu_event_read | Date | Tue, 04 Jul 2023 11:37:04 +0300 |
| |
On Tue, 04 Jul 2023, Uros Bizjak <ubizjak@gmail.com> wrote: > On Tue, Jul 4, 2023 at 9:28 AM Jani Nikula <jani.nikula@linux.intel.com> wrote: >> You could save everyone a lot of time by actually documenting what these >> functions do. Assume you don't know what local64_try_cmpxchg() does, and >> see how many calls you have to go through to figure it out. > > These functions are documented in Documentation/atomic_t.txt (under > "RMW ops:" section), and the difference is explained in a separate > section "CMPXCHG vs TRY_CMPXCGS" in the same file.
Thanks, but *sigh*.
No kernel-doc above the functions, not even a regular comment referencing atomic_t.txt.
$ git grep local.*_try -- Documentation [nothing]
BR, Jani.
--
"But the plans were on display..."
"On display? I eventually had to go down to the cellar to find them."
"That's the display department."
"With a flashlight."
"Ah, well, the lights had probably gone."
"So had the stairs."
"But look, you found the notice, didn't you?"
"Yes," said Arthur, "yes I did. It was on display in the bottom of a locked filing cabinet stuck in a disused lavatory with a sign on the door saying 'Beware of the Leopard'."
- Douglas Adams, The Hitchhiker's Guide to the Galaxy
-- Jani Nikula, Intel Open Source Graphics Center
| ![\](/images/icornerr.gif) |