Messages in this thread | | | Date | Tue, 4 Jul 2023 10:35:02 +0200 | From | Miquel Raynal <> | Subject | Re: [RFC PATCH v1 1/2] dt-bindings: nand: meson: support for 512B ECC step size |
| |
Hi Arseniy,
AVKrasnov@sberdevices.ru wrote on Wed, 28 Jun 2023 12:29:35 +0300:
> Meson NAND supports both 512B and 1024B ECC step size, so replace > 'const' for only 1024B step size with enum for both sizes. > > Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru> > --- > Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > index 3bec8af91bbb..d42daa285d17 100644 > --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > @@ -49,7 +49,7 @@ patternProperties: > const: hw > > nand-ecc-step-size: > - const: 1024 > + enum: [512, 1024]
I believe you should as well mention the default value.
> nand-ecc-strength: > enum: [8, 16, 24, 30, 40, 50, 60] > @@ -93,6 +93,7 @@ examples: > nand@0 { > reg = <0>; > nand-rb = <0>; > + nand-ecc-step-size = <1024>;
And I don't think this line is really required, but I don't mind.
> }; > }; >
Thanks, Miquèl
| |