Messages in this thread | | | From | Shinichiro Kawasaki <> | Subject | Re: [PATCH blktests v3 0/3] More fixes for FC enabling | Date | Tue, 4 Jul 2023 07:08:57 +0000 |
| |
On Jul 03, 2023 / 11:16, Daniel Wagner wrote: > I've rebased the series on the current HEAD and moved the def_hostnqn bits from > the second patch to the third. This should make it more consistent in commit > history. > > Also retested and found a bug in the context matching code in libnvme which I > post a fix too.
Thanks Daniel.
One thing I noticed is that now the 3rd patch removes the references from nvme/rc to /etc/nvme/hostid and /etc/nvme/hostnqn. I'm ok with this change since I see the motivation discussed here [1]. I will wait for several days to make sure it's ok for others. In case anyone relies on those files to set up blktests environment, please speak up.
[1] https://lore.kernel.org/linux-nvme/ajcm6yupguickaucansiuzjqatyz5qijnnp4topxv64cisbblc@4sgv3bd3jl4q/
Other that, changes in v3 looks good to me. If there is no voice, I'll apply the patches as they are.
| |