Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 4 Jul 2023 15:04:38 +0800 | Subject | Re: [PATCH v6 2/7] dt-bindings: soc: starfive: Add StarFive syscon module | From | Xingyu Wu <> |
| |
On 2023/7/4 14:30, Krzysztof Kozlowski wrote: > On 04/07/2023 04:02, Xingyu Wu wrote: >> From: William Qiu <william.qiu@starfivetech.com> >> >> Add documentation to describe StarFive System Controller Registers. >> >> Co-developed-by: Xingyu Wu <xingyu.wu@starfivetech.com> >> Signed-off-by: Xingyu Wu <xingyu.wu@starfivetech.com> >> Signed-off-by: William Qiu <william.qiu@starfivetech.com> > > I don't think there is a point in reviewing bindings which were never > tested. I hope you agree with me. > > The patch just introduces errors. :( >
Sorry, it was my fault. I tested it but found the example uncompleted. And I forgot to test it after completing it. Sorry.
Best regards, Xingyu Wu
| ![\](/images/icornerr.gif) |