lkml.org 
[lkml]   [2023]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject回复: [PATCH] block: mq-deadline: rename so rt list to sort rb
Date
>> Mq-deadline would store request in list:fifo_list and 
>> rb_tree:sort_list, and sort_list should be renamed to sort_rb which is
>> beneficial for understanding.

>Huh? I think this patch makes the code less readable instead of more readable ...

Huh? Maybe we had different opinions about it, I thinks the essence of this word is 'sort'
So that reader can get the meaning of it easily. And in my mind, *_rb is more reasonable
for rb_root ratherthan *_list for reader.

-----邮件原件-----
发件人: Bart Van Assche <bvanassche@acm.org>
发送时间: 2023年7月4日 22:13
收件人: 李培锋(wink) <lipeifeng@oppo.com>; axboe@kernel.dk
抄送: linux-block@vger.kernel.org; linux-kernel@vger.kernel.org; 张诗明(Simon Zhang) <zhangshiming@oppo.com>; 郭健 <guojian@oppo.com>
主题: Re: [PATCH] block: mq-deadline: rename sort_list to sort_rb

On 7/3/23 21:06, lipeifeng@oppo.com wrote:
> Mq-deadline would store request in list:fifo_list and
> rb_tree:sort_list, and sort_list should be renamed to sort_rb which is
> beneficial for understanding.

Huh? I think this patch makes the code less readable instead of more readable ...

Bart.
\
 
 \ /
  Last update: 2023-07-05 02:31    [W:0.062 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site