Messages in this thread | | | Date | Fri, 28 Jul 2023 15:54:10 -0300 | From | Jason Gunthorpe <> | Subject | Re: [PATCH v1 2/7] iommu/arm-smmu-v3: Replace s1_cfg with ctx_desc_cfg |
| |
On Fri, Jul 28, 2023 at 11:41:26AM -0700, Nicolin Chen wrote: > On Fri, Jul 28, 2023 at 09:22:52AM -0300, Jason Gunthorpe wrote: > > On Fri, Jul 28, 2023 at 03:47:45PM +0800, Michael Shavit wrote: > > > On Fri, Jul 28, 2023 at 4:57 AM Nicolin Chen <nicolinc@nvidia.com> wrote: > > > > > > > It'd be nicer to align all the variables to "cd_table" like the > > > > 2nd piece here. And if we rename the struct name too: > > > > > > > > struct arm_smmu_cdtab_cfg *cd_table = xxxx; > > > > > > I agree that renaming these would be nice. There's 36 usages of cdcfg > > > in arm-smmu-v3.c, and 6 usages of arm_smmu_ctx_desc_cfg. > > > I can rename the struct since we'll be touching many of those in this > > > patch anyways, but I'm a bit concerned of the churn from updating all > > > the cdcfg usages. > > > > Will was not keen on churn for clarity so it seem better to be > > thoughtful about what is touched to get this merged. > > Still, it would be odd to have "cdcfg" and "cd_table" at the same > time. If we have to be conservative, perhaps we should just align > with the old naming: "struct arm_smmu_ctx_desc_cfg *cdcfg;"...
Yeah, I think changing to cd_table in the places touched makes alot of sense
Jason
| |