lkml.org 
[lkml]   [2023]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
SubjectRe: [PATCH -next] drm/fb-helper: Remove unused inline function drm_fb_helper_defio_init()
From
Hi

Am 21.07.23 um 14:09 schrieb YueHaibing:
> Since commit 8e86dee02253 ("drm/fb-helper: Remove drm_fb_helper_defio_init() and update docs")
> this inline helper not used anymore.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

You need to add a Fixes: tag here with the commit you mentioned in the
description.

With this fixed, you can also add

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Best regards
Thomas

> ---
> include/drm/drm_fb_helper.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index 4863b0f8299e..375737fd6c36 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -368,11 +368,6 @@ static inline void drm_fb_helper_deferred_io(struct fb_info *info,
> {
> }
>
> -static inline int drm_fb_helper_defio_init(struct drm_fb_helper *fb_helper)
> -{
> - return -ENODEV;
> -}
> -
> static inline void drm_fb_helper_set_suspend(struct drm_fb_helper *fb_helper,
> bool suspend)
> {

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2023-07-24 16:27    [W:0.081 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site