lkml.org 
[lkml]   [2023]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] mtd: use refcount to prevent corruption
    Hi Alexander,

    alexander.usyskin@intel.com wrote on Mon, 24 Jul 2023 11:43:59 +0000:

    > > > > > With this patch applied, when I load up the module, I get the same 3
    > > > > > devices:
    > > > > > /dev/mtd0
    > > > > > /dev/mtd0ro
    > > > > > /dev/mtdblock0
    > > > > >
    > > > > > Upon removal, the below 2 devices still hang around:
    > > > > > /dev/mtd0
    > > > > > /dev/mtd0ro
    > > > >
    > > > Our use-case do not produce mtdblock, maybe there are some imbalances
    > > of get/put?
    > > > I have somewhere version with pr_debug after every kref_get/put. That may
    > > help to catch where
    > > > it missed, I hope.
    > >
    > > I believe mtdblock is the good citizen here. Just disable
    > > CONFIG_MTD_BLOCK from your configuration and you will likely observe
    > > the same issue, just a bit narrowed, perhaps. Indeed, if you manage to
    > > follow all the get/put calls it can help to find an imbalance.
    > >
    > > Thanks,
    > > Miquèl
    >
    > Miquel, do you have CONFIG_MTD_PARTITIONED_MASTER set in your config?

    Not sure I get your question. You can enable or disable it, it should
    work in both cases (yet, the handling is of course a bit different as
    the top level device will be retained/not retained).

    Thanks,
    Miquèl

    \
     
     \ /
      Last update: 2023-07-24 13:51    [W:4.268 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site