lkml.org 
[lkml]   [2023]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 7/8] iio: core: Move initcalls closer to the respective calls
On Sun, Jul 23, 2023 at 10:23:35AM +0100, Jonathan Cameron wrote:
> On Fri, 21 Jul 2023 20:00:21 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
> > Move subsys_initcall() and module_exit() closer to the respective calls.
>
> Why? For this particular set of macros I can see advantages to them being
> near the code and to them being in a fairly predictable location (end of
> file).
>
> I think the patch description should make the why argument.

The documented case is about exported symbols.
Now I looked for the module_*() stuff and there is no consensus
between subsystems. Both styles are being documented and used.

I think I may drop this. Someone also can investigate the trends,
but I won't spend my time on this.

Thank you for the review.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-07-24 12:54    [W:0.161 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site