lkml.org 
[lkml]   [2023]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4] ata: pata_arasan_cf: Use dev_err_probe() instead dev_err() in data_xfer()
From
On 7/24/23 18:57, Minjie Du wrote:
> It is possible for dma_request_chan() to return EPROBE_DEFER, which means
> acdev->host->dev is not ready yet.
> At this point dev_err() will have no output.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> V1 - V4:
> Fix code format.

You are not fixing anything. You keep resending the same, which is missing the
dev_err_probe() message alignment like I (and Sergey) keep telling you. Can you
please take our comments seriously and act on them ? If you do not understand,
then say so and I will explain in more details.

> ---
> drivers/ata/pata_arasan_cf.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c
> index 6ab294322e79..b32d47112c0a 100644
> --- a/drivers/ata/pata_arasan_cf.c
> +++ b/drivers/ata/pata_arasan_cf.c
> @@ -529,7 +529,8 @@ static void data_xfer(struct work_struct *work)
> /* dma_request_channel may sleep, so calling from process context */
> acdev->dma_chan = dma_request_chan(acdev->host->dev, "data");
> if (IS_ERR(acdev->dma_chan)) {
> - dev_err(acdev->host->dev, "Unable to get dma_chan\n");
> + dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
> + "Unable to get dma_chan\n");

Just use this please, formatted *exactly* like this.

dev_err_probe(acdev->host->dev, PTR_ERR(acdev->dma_chan),
"Unable to get dma_chan\n");

> acdev->dma_chan = NULL;
> goto chan_request_fail;
> }

--
Damien Le Moal
Western Digital Research

\
 
 \ /
  Last update: 2023-07-24 12:40    [W:0.045 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site