lkml.org 
[lkml]   [2023]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] m68k: sun3: idprom: ERROR: "foo* bar" should be "foo *bar"
    On Thu, Jul 13, 2023 at 10:09 AM <hexingwei001@208suo.com> wrote:
    > Fix one occurrences of the checkpatch.pl error:
    > ERROR: "foo* bar" should be "foo *bar"
    >
    > Signed-off-by: Xingwei He <hexingwei001@208suo.com>

    Thanks for your patch!
    But obviously you forgot to run scripts/checkpatch.pl on your own patch:

    WARNING: From:/Signed-off-by: email name mismatch: 'From:
    hexingwei001@208suo.com' != 'Signed-off-by: Xingwei He
    <hexingwei001@208suo.com>'

    > --- a/arch/m68k/sun3/idprom.c
    > +++ b/arch/m68k/sun3/idprom.c
    > @@ -83,7 +83,7 @@ static void __init display_system_type(unsigned char
    > machtype)
    > prom_halt();
    > }
    >
    > -void sun3_get_model(unsigned char* model)
    > +void sun3_get_model(unsigned char *model)
    > {
    > register int i;

    Whitespace-damaged, so it fails to apply.

    These problems are present in all your patches, so something is\
    wrong in your workflow. Please test your patches by running
    scripts/checkpatch.pl, emailing them to yourself, and trying to
    apply them.

    Thanks!

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds

    \
     
     \ /
      Last update: 2023-07-24 11:02    [W:9.150 / U:0.140 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site