lkml.org 
[lkml]   [2023]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu binding doc
Date


> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Thursday, July 13, 2023 12:12 AM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Gaurav
> Jain <gaurav.jain@nxp.com>; linux-kernel@vger.kernel.org; Daniel Baluta
> <daniel.baluta@nxp.com>
> Subject: Re: [EXT] Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu binding
> doc
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On 10/07/2023 19:52, Pankaj Gupta wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: Friday, June 16, 2023 6:51 PM
> >> To: Pankaj Gupta <pankaj.gupta@nxp.com>; robh+dt@kernel.org;
> >> krzysztof.kozlowski+dt@linaro.org; conor+dt@kernel.org;
> >> shawnguo@kernel.org; s.hauer@pengutronix.de; kernel@pengutronix.de;
> >> festevam@gmail.com; dl-linux-imx <linux-imx@nxp.com>;
> >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org;
> >> Gaurav Jain <gaurav.jain@nxp.com>; linux-kernel@vger.kernel.org;
> >> Daniel Baluta <daniel.baluta@nxp.com>
> >> Subject: [EXT] Re: [PATCH v3 1/7] dt-bindings: arm: fsl: add mu
> >> binding doc
> >>
> >> Caution: This is an external email. Please take care when clicking
> >> links or opening attachments. When in doubt, report the message using
> >> the 'Report this email' button
> >>
> >>
> >> On 16/06/2023 20:11, Pankaj Gupta wrote:
> >>> The NXP i.MX Message Unit enables two processing elements to
> >>> communicate & co-ordinate with each other. This driver is used to
> >>> communicate between Application Core and NXP HSM IPs like NXP
> >> EdgeLock
> >>> Enclave etc.
> >>> It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
> >>>
> >>> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> >>
> >> I don't see reply to Daniel's concerns.
> >>
> >> I don't see improvements here based on the previous review you received.
> >> It seems you just ignored everything, right?
> > Replied to Daniel's concern.
> >
> >>
> >> Limited review follows up because binding is not in the shape for upstream.
> >> Do some internal reviews prior sending it.
> > Done the internal review.
>
> I doubt. Your v4 bindings and DTS were not tested. v4 Driver has trivial issues.
>
It is tested and my driver get probed. And all my functional tests are passing.
No Patch-set is sent without testing.

> Best regards,
> Krzysztof

\
 
 \ /
  Last update: 2023-07-24 08:40    [W:0.360 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site