Messages in this thread | | | Date | Mon, 24 Jul 2023 10:24:19 -0600 | From | Rob Herring <> | Subject | Re: [PATCH 1/3] media: dt-bindings: samsung,exynos4212-fimc-is: replace duplicate pmu node with phandle |
| |
On Sat, 22 Jul 2023 13:54:39 +0200, Krzysztof Kozlowski wrote: > The FIMC IS camera must access the PMU (Power Management Unit) IO memory > to control camera power. This was achieved by duplicating the PMU node > as its child like: > > soc@0 { > system-controller@10020000 { ... }; // Real PMU > > camera@11800000 { > fimc-is@12000000 { > // FIMC IS camera node > pmu@10020000 { > reg = <0x10020000 0x3000>; // Fake PMU node > }; > }; > }; > }; > > This is not a correct representation of the hardware. Mapping the PMU > (Power Management Unit) IO memory should be via syscon-like phandle > (samsung,pmu-syscon, already used for other drivers), not by duplicating > "pmu" Devicetree node inside the FIMC IS. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../media/samsung,exynos4212-fimc-is.yaml | 15 ++++++++++----- > .../devicetree/bindings/media/samsung,fimc.yaml | 5 +---- > 2 files changed, 11 insertions(+), 9 deletions(-) >
Reviewed-by: Rob Herring <robh@kernel.org>
| |