Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 21 Jul 2023 17:14:46 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH] firmware: Explicitly include correct DT includes |
| |
On Fri, Jul 14, 2023 at 11:44:37AM -0600, Rob Herring wrote: > The DT of_device.h and of_platform.h date back to the separate > of_platform_bus_type before it as merged into the regular platform bus. > As part of that merge prepping Arm DT support 13 years ago, they > "temporarily" include each other. They also include platform_device.h > and of.h. As a result, there's a pretty much random mix of those include > files used throughout the tree. In order to detangle these headers and > replace the implicit includes with struct declarations, users need to > explicitly include the correct includes. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > drivers/firmware/arm_scmi/driver.c | 4 ++-- > drivers/firmware/imx/imx-dsp.c | 1 - > drivers/firmware/imx/imx-scu-irq.c | 1 + > drivers/firmware/imx/imx-scu.c | 1 + > drivers/firmware/mtk-adsp-ipc.c | 1 - > drivers/firmware/raspberrypi.c | 1 + > drivers/firmware/scpi_pm_domain.c | 3 ++- > drivers/firmware/stratix10-rsu.c | 1 - > drivers/firmware/tegra/bpmp.c | 3 +-- > drivers/firmware/xilinx/zynqmp.c | 1 + > 10 files changed, 9 insertions(+), 8 deletions(-)
Not sure about the other maintainers, but I usually pick up firmware/tegra patches up through the Tegra tree and then they ultimately go through ARM SoC.
Arnd, Olof, does it make sense for you guys to pick this up directly?
Thierry [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |