Messages in this thread | | | Date | Fri, 21 Jul 2023 14:02:54 +0200 | Subject | Re: [PATCH v3 1/2] dt-bindings: iio: dac: add mcp4728.yaml | From | Andrea Collamati <> |
| |
On 7/21/23 10:22, Krzysztof Kozlowski wrote: > On 21/07/2023 10:21, Krzysztof Kozlowski wrote: >>> + - | >>> + i2c { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + mcp4728@60 { >> The same... Probably more comments were ignored, so: >> >> This is a friendly reminder during the review process. >> >> It seems my previous comments were not fully addressed. Maybe my >> feedback got lost between the quotes, maybe you just forgot to apply it. >> Please go back to the previous discussion and either implement all >> requested changes or keep discussing them.
Sorry, you are right. I missed to change the node name.
{
#address-cells = <1>; #size-cells = <0>;
dac@60 {
could be ok?
Thank you
Andrea
| |