Messages in this thread | | | Date | Fri, 21 Jul 2023 10:44:01 +0100 | From | Conor Dooley <> | Subject | Re: [PATCH 01/11] RISC-V: drivers/iommu: Add RISC-V IOMMU - Ziommu support. |
| |
On Wed, Jul 19, 2023 at 02:43:51PM -0700, Tomasz Jeznach wrote: > On Wed, Jul 19, 2023 at 1:50 PM Conor Dooley <conor@kernel.org> wrote:
> > Also, since I am not going to reply to any of these iommu driver patches > > in a meaningful capacity, please run checkpatch.pl on your work. There > > are well over 100 style etc complaints that it has highlighted. Sparse > > has also gone a bit nuts, with many warnings along the lines of: > > drivers/iommu/riscv/iommu.c:1568:29: warning: incorrect type in assignment (different base types) > > drivers/iommu/riscv/iommu.c:1568:29: expected unsigned long long [usertype] iohgatp > > drivers/iommu/riscv/iommu.c:1568:29: got restricted __le64 [usertype] > > > > I can provide you the full list when the patchwork automation has run > > through the series. > > > > Thank you, a list of used lint checkers definitely would help.
checkpatch is mentioned in the patch submission documentation ;)
Anyway, here's the series on patchwork: https://patchwork.kernel.org/project/linux-riscv/list/?series=767543 You can see there's quite a few failure for each patch, so you'll need to resolve those.
Also, I noticed the 32-bit build is broken in some patches, so please build this driver for 32-bit before sending a v2.
Thanks, Conor. [unhandled content-type:application/pgp-signature] | |