Messages in this thread | | | Date | Tue, 18 Jul 2023 22:00:41 +0800 | Subject | Re: [PATCH v3 0/2] soc: hisilicon: Support HCCS driver on Kunpeng SoC | From | "lihuisong (C)" <> |
| |
在 2023/7/18 18:59, Krzysztof Kozlowski 写道: > On 18/07/2023 10:07, lihuisong (C) wrote: >> Hi Krzysztof, >> >> Thank you for your reply. >> >> >> 在 2023/7/17 20:06, Krzysztof Kozlowski 写道: >>> On 14/07/2023 08:17, lihuisong (C) wrote: >>>> Hi all, >>>> >>>> Can you take a look at this series? >>> People you listed in "To:" field are not maintainers of HiSilicon, so >>> why pinging us? >> This "To:" field are from the get_maintainer.pl script. >> ./scripts/get_maintainer.pl -f ./drivers/soc/ > Which is not really correct. Why would you send it to maintainers of > Samsung or NXP? Yeah, that's not entirely correct. I should skip other SOC maintainers from the output of the script. The reason why I send to some maintainers in "To" field is that some of them have kindly reviewed my patch before. > >> The hisilicon in drivers/soc/ is created for the first time. So there >> are no maintainer of HiSilicon. > There are. Open MAINTAINERS file, use search and voila. got it, thanks. > >> Thanks for reminder. >> add HiSilicon SOC maintainer Wei Xu. >>> HiSilicon DTS has numerous issues, so if you want to increase the >>> chances anyone cares about your patch, please contribute to fixing and >>> improving your company DTS. See for example commit b2bbc8687 which is >>> bad (underscores are not allowed) or 1860a51823 which is just wrong. The >>> latter one is being fixed, although I do not see the fix being picked >>> up... my feelings are the platform is just dead. >> The HCCS driver has nothing to do with HiSilicon DTS. >> So I cannot understand why you say DTS. > I grunted about poor support for HiSilicon. Because both - HiSilicon DTS > and HiSilicon SoC HCCS driver - are for HiSilicon.
This driver works on kunpneg SOC platform, which isn't related to something you mentioned.
> > Now, why don't you help the maintainers review/fix stuff so they will > have more time for your patch? Yes, this is helpful and reasonable. Would do it if I have the chance.
Best regards, Huisong
| |