Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 11 Jul 2023 08:51:38 -0700 | From | Kees Cook <> | Subject | Re: [PATCH v2 1/2] binfmt_elf_fdpic: support 64-bit systems |
| |
On Tue, Jul 11, 2023 at 11:07:53PM +1000, Greg Ungerer wrote: > The binfmt_flat_fdpic code has a number of 32-bit specific data > structures associated with it. Extend it to be able to support and > be used on 64-bit systems as well. > > The new code defines a number of key 64-bit variants of the core > elf-fdpic data structures - along side the existing 32-bit sized ones. > A common set of generic named structures are defined to be either > the 32-bit or 64-bit ones as required at compile time. This is a > similar technique to that used in the ELF binfmt loader. > > For example: > > elf_fdpic_loadseg is either elf32_fdpic_loadseg or elf64_fdpic_loadseg > elf_fdpic_loadmap is either elf32_fdpic_loadmap or elf64_fdpic_loadmap > > the choice based on ELFCLASS32 or ELFCLASS64. > > Signed-off-by: Greg Ungerer <gerg@kernel.org>
This looks good an is consistent with what the regular ELF loader does with the sized types.
Acked-by: Kees Cook <keescook@chromium.org>
-- Kees Cook
| ![\](/images/icornerr.gif) |