lkml.org 
[lkml]   [2023]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] perf probe: read DWARF files from the correct CU
Em Tue, Jul 11, 2023 at 10:20:00PM +0900, Masami Hiramatsu escreveu:
> On Tue, 11 Jul 2023 09:57:45 -0300 Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
> > Em Thu, Jun 15, 2023 at 10:01:37PM +0200, Georg Müller escreveu:
> > > The problem is that die_get_decl_file() uses the wrong CU to search for
> > > the file. elfutils commit e1db5cdc9f has some good explanation for this:
> > >
> > > dwarf_decl_file uses dwarf_attr_integrate to get the DW_AT_decl_file
> > > attribute. This means the attribute might come from a different DIE
> > > in a different CU. If so, we need to use the CU associated with the
> > > attribute, not the original DIE, to resolve the file name.
> > >
> > > This patch uses the same source of information as elfutils: use attribute
> > > DW_AT_decl_file and use this CU to search for the file.
> >
> > Thanks, applied to the perf-tools branch, that will be submitted for
> > Linux v6.5.

> Thanks Arnaldo and Georg,

> It sounds perfect reason why that happened. I didn't expect the case that
> the attribute comes from another CU...

> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>

Thanks, added it to the cset.

- Arnaldo

\
 
 \ /
  Last update: 2023-07-11 16:42    [W:0.074 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site