Messages in this thread | | | Date | Tue, 11 Jul 2023 14:09:06 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 1/2] blk-flush: fix rq->flush.seq for post-flush requests |
| |
On Tue, Jul 11, 2023 at 07:52:11PM +0800, Chengming Zhou wrote: > On 2023/7/11 19:31, Christoph Hellwig wrote: > > On Tue, Jul 11, 2023 at 07:06:20PM +0800, Chengming Zhou wrote: > >> Ok, will add a Fixes tag and send it as a separate patch since it's a bug fix. > > > > Btw, it's probably not worth resending patch 2 until we've figured out > > and dealt with the SATA flush regression that Chuck reported. > > Ok, I will not resend patch 2. As for the patch 1, should I resend it as a separate patch > or just put it in that series [1] before other flush optimizations ?
I'd wait a bit for debugging the regression. For the worst case we'll have to revert the patch, which currently can be done cleanly, but can't be with that patch.
| |