lkml.org 
[lkml]   [2023]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] cgroup: remove unneeded return value of cgroup_rm_cftypes_locked()
    On Tue, Jul 11, 2023 at 10:58:48AM +0800, Miaohe Lin <linmiaohe@huawei.com> wrote:
    > +/* It builds upon cgroup_addrm_files()'s. */
    > static void cgroup_rm_cftypes_locked(struct cftype *cfts)
    > {
    > lockdep_assert_held(&cgroup_mutex);
    >

    I meant adding the reasoning to the commit message -- swallowing errors
    on removal is fine because cgroup_addrm_files() won't fail at removal.
    It's a minor remark for the future readers ;-)

    Michal
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-07-11 13:21    [W:6.168 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site