Messages in this thread | | | Date | Tue, 11 Jul 2023 13:21:39 +0200 | From | Michal Koutný <> | Subject | Re: [PATCH] cgroup: remove unneeded return value of cgroup_rm_cftypes_locked() |
| |
On Tue, Jul 11, 2023 at 10:58:48AM +0800, Miaohe Lin <linmiaohe@huawei.com> wrote: > +/* It builds upon cgroup_addrm_files()'s. */ > static void cgroup_rm_cftypes_locked(struct cftype *cfts) > { > lockdep_assert_held(&cgroup_mutex); >
I meant adding the reasoning to the commit message -- swallowing errors on removal is fine because cgroup_addrm_files() won't fail at removal. It's a minor remark for the future readers ;-)
Michal [unhandled content-type:application/pgp-signature] | |