Messages in this thread | | | Date | Tue, 11 Jul 2023 11:23:40 +0200 | Subject | Re: [PATCH v2 1/3] dt-bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET | From | Krzysztof Kozlowski <> |
| |
On 11/07/2023 11:17, huaqian.li@siemens.com wrote: > From: Li Hua Qian <huaqian.li@siemens.com> > > TI RTI (Real Time Interrupt) Watchdog doesn't support to record the > watchdog cause. Add a reserved memory to know the last reboot was caused > by the watchdog card. In the reserved memory, some specific info will be > saved to indicate whether the watchdog reset was triggered in last > boot. > > Signed-off-by: Li Hua Qian <huaqian.li@siemens.com> > ---
Missing changelog.
> .../devicetree/bindings/watchdog/ti,rti-wdt.yaml | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml > index fc553211e42d..f227db08dc70 100644 > --- a/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/ti,rti-wdt.yaml > @@ -26,7 +26,18 @@ properties: > - ti,j7-rti-wdt > > reg: > - maxItems: 1 > + maxItems: 2
The expected syntax is in such case: items: - description: ... - description: ...
You will find plenty of examples for this.
> + description: > + - Contains the address and the size of MCU RTI register. > + - Contains the address and the size of reserved memory, which
I don't think Conor suggested using reg of the device, but reg of reserved memory. This is not device address space, but just some random memory.
memory-region seems proper to me. We were just discussing totally useless new property of size.
What's more - you did not test it... so usual template:
It does not look like you tested the DTS against bindings. Please run `make dtbs_check` (see Documentation/devicetree/bindings/writing-schema.rst or https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/ for instructions).
Best regards, Krzysztof
| |