lkml.org 
[lkml]   [2023]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] ACPI: NFIT: limit string attribute write
    Date
    If we're writing what could be an arbitrary sized string into an attribute
    we should probably use sysfs_emit() just to be safe. Most of the other
    attriubtes are some sort of integer so unlikely to be an issue so not
    altered at this time.

    Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
    ---
    v2:
    - use sysfs_emit() instead of snprintf.
    ---
    drivers/acpi/nfit/core.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
    index 9213b426b125..d7e9d9cd16d2 100644
    --- a/drivers/acpi/nfit/core.c
    +++ b/drivers/acpi/nfit/core.c
    @@ -1579,7 +1579,7 @@ static ssize_t id_show(struct device *dev,
    {
    struct nfit_mem *nfit_mem = to_nfit_mem(dev);

    - return sprintf(buf, "%s\n", nfit_mem->id);
    + return snprintf(buf, PAGE_SIZE, "%s\n", nfit_mem->id);
    }
    static DEVICE_ATTR_RO(id);

    --
    2.40.1
    \
     
     \ /
      Last update: 2023-07-11 11:28    [W:3.835 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site