lkml.org 
[lkml]   [2023]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] io_uring: Redefined the meaning of io_alloc_async_data's return value
On Mon, Jul 10, 2023 at 12:58:58PM -0400, Gabriel Krisman Bertazi wrote:
> practice to change the symbol, making the change hard to miss. Or
> make the function return int instead of bool, which preserves the
> interface and is a common C idiom. Or leave it as it is, which is quite
> readable already..

Yeah, returning -ENOMEM and 0 would make a lot more sense here. But I'd
only change it if we have any good reason to touch the interface anyway.

\
 
 \ /
  Last update: 2023-07-11 07:07    [W:0.047 / U:0.336 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site