Messages in this thread | | | From | "Chanho Park" <> | Subject | RE: [PATCH] spi: s3c64xx: clear loopback bit after loopback test | Date | Tue, 11 Jul 2023 17:43:08 +0900 |
| |
Hi Jaewon,
> -----Original Message----- > From: Jaewon Kim <jaewon02.kim@samsung.com> > Sent: Tuesday, July 11, 2023 5:20 PM > To: Andi Shyti <andi.shyti@kernel.org>; Mark Brown <broonie@kernel.org>; > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Alim Akhtar > <alim.akhtar@samsung.com> > Cc: linux-spi@vger.kernel.org; linux-samsung-soc@vger.kernel.org; linux- > arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Chanho Park > <chanho61.park@samsung.com>; Jaewon Kim <jaewon02.kim@samsung.com> > Subject: [PATCH] spi: s3c64xx: clear loopback bit after loopback test > > When SPI loopback transfer is performed, S3C64XX_SPI_MODE_SELF_LOOPBACK > bit still remained. It works as loopback even if the next transfer is not > spi loopback mode. > If not SPI_LOOP, needs to clear S3C64XX_SPI_MODE_SELF_LOOPBACK bit. >
In order for this patch to be sent to the stable tree, below tag is required. Fixes: ffb7bcd3b27e ("spi: s3c64xx: support loopback mode")
Otherwise, looks good to me. Reviewed-by: Chanho Park <chanho61.park@samsung.com>
Best Regards, Chanho Park
> Signed-off-by: Jaewon Kim <jaewon02.kim@samsung.com> > --- > drivers/spi/spi-s3c64xx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index > fd55697144cc..b6c2659a66ca 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -684,6 +684,8 @@ static int s3c64xx_spi_config(struct > s3c64xx_spi_driver_data *sdd) > > if ((sdd->cur_mode & SPI_LOOP) && sdd->port_conf->has_loopback) > val |= S3C64XX_SPI_MODE_SELF_LOOPBACK; > + else > + val &= ~S3C64XX_SPI_MODE_SELF_LOOPBACK; > > writel(val, regs + S3C64XX_SPI_MODE_CFG); > > -- > 2.17.1
| |