lkml.org 
[lkml]   [2023]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: 回复: [PATCH v2] lib:Fix more error checking for debugfs create dir()
From


On 7/11/23 18:20, 王明-软件底层技术部 wrote:
> Hi Randy.
> The only maintainers I obtained using get_maintainer.pl were LKML, and there seems to be no other maintainers
> Do you have any good suggestions?: )
>

Use 'git log lib/test_fpu.c' to see who merges patches to it.

> ~Ming
> -----邮件原件-----
> 发件人: Randy Dunlap <rdunlap@infradead.org>
> 发送时间: 2023年7月12日 3:33
> 收件人: 王明-软件底层技术部 <machel@vivo.com>; linux-kernel@vger.kernel.org
> 抄送: opensource.kernel <opensource.kernel@vivo.com>
> 主题: Re: [PATCH v2] lib:Fix more error checking for debugfs_create_dir()
>
> [Some people who received this message don't often get email from rdunlap@infradead.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> Hi--
>
> On 7/11/23 04:16, Wang Ming wrote:
>> In case of failure, debugfs_create_dir() does not return NULL, but an
>> error pointer. Most incorrect error checks were fixed, but the one in
>> test_fpu_init() was forgotten.
>>
>> Fix the remaining error check.
>>
>> Signed-off-by: Wang Ming <machel@vivo.com>
>
> You need to send this to some maintainer who can merge it, so please an appropriate maintainer to send it to.
>
> Thanks.
>
>> ---
>> lib/test_fpu.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/test_fpu.c b/lib/test_fpu.c index
>> e82db19fed84..5d6aa4691b4a 100644
>> --- a/lib/test_fpu.c
>> +++ b/lib/test_fpu.c
>> @@ -69,7 +69,7 @@ static struct dentry *selftest_dir; static int
>> __init test_fpu_init(void) {
>> selftest_dir = debugfs_create_dir("selftest_helpers", NULL);
>> - if (!selftest_dir)
>> + if (IS_ERR(selftest_dir))
>> return -ENOMEM;
>>
>> debugfs_create_file_unsafe("test_fpu", 0444, selftest_dir, NULL,
>
> --
> ~Randy

--
~Randy

\
 
 \ /
  Last update: 2023-07-12 04:59    [W:1.936 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site