Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 12 Jul 2023 09:42:41 +0800 | From | Xu Yilun <> | Subject | Re: [PATCH v2 3/3] fpga: socfpga-a10: Fix incorrect return value of devm_regmap_init_mmio |
| |
On 2023-07-10 at 16:11:35 +0200, Greg Kroah-Hartman wrote: > On Mon, Jul 10, 2023 at 09:38:30PM +0800, Yangtao Li wrote: > > When devm_regmap_init_mmio fails, we should return PTR_ERR(priv->regmap) > > instead of -ENODEV. > > > > Fixes: acbb910ae04b ("fpga-manager: Add Socfpga Arria10 support") > > Why are you not also including a cc: stable@ tag here?
The change is to propagate the error number produced by regmap, instead of using a fixed error number.
I think this is more of an improvement, not a bug fix. So no need to merge to stable? And the changelog should be improved to avoid confusing.
Thanks, Yilun
> > thanks, > > greg k-h
| ![\](/images/icornerr.gif) |