Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 12 Jul 2023 08:46:13 +0800 | From | Baoquan He <> | Subject | Re: [PATCH 5/8] net: altera-tse: make ALTERA_TSE depend on HAS_IOMEM |
| |
On 07/11/23 at 06:17pm, Simon Horman wrote: > On Fri, Jul 07, 2023 at 09:58:49PM +0800, Baoquan He wrote: > > On s390 systems (aka mainframes), it has classic channel devices for > > networking and permanent storage that are currently even more common > > than PCI devices. Hence it could have a fully functional s390 kernel > > with CONFIG_PCI=n, then the relevant iomem mapping functions > > [including ioremap(), devm_ioremap(), etc.] are not available. > > > > Here let ALTERA_TSE depend on HAS_IOMEM so that it won't be built > > to cause below compiling error if PCI is unset: > > > > ------ > > ERROR: modpost: "devm_ioremap" [drivers/net/ethernet/altera/altera_tse.ko] undefined! > > ------ > > > > Reported-by: kernel test robot <lkp@intel.com> > > Closes: https://lore.kernel.org/oe-kbuild-all/202306211329.ticOJCSv-lkp@intel.com/ > > Signed-off-by: Baoquan He <bhe@redhat.com> > > > Reviewed-by: Simon Horman <simon.horman@corigine.com> > Tested-by: Simon Horman <simon.horman@corigine.com> # build-tested
Thanks, Simon.
> > I wonder if this should also have: > > Fixes: ed33ef648964 ("Altera TSE: Add Altera Ethernet Driver Makefile and Kconfig")
Agree, it's worth having Fixes tag.
| ![\](/images/icornerr.gif) |