lkml.org 
[lkml]   [2023]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] libbpf: fix some typo of hashmap init
On 7/11/23 05:12, Andrii Nakryiko wrote:

> On Mon, Jul 10, 2023 at 10:25 AM Stanislav Fomichev<sdf@google.com> wrote:
>> On 07/10, John Sanpe wrote:
>>> Remove the whole HASHMAP_INIT. It's not used anywhere in libbpf.
>>>
>>> Signed-off-by: John Sanpe<sanpeqf@gmail.com>
>> Acked-by: Stanislav Fomichev<sdf@google.com>
>>
>> Doesn't look like it was ever used.
> Ack for the change, but the subject doesn't correspond to the change
> itself. You are not fixing typo, you are removing static
> initialization helper.

Thanks for your suggestion, I have merged the two commits and used a
more reasonable subject in v3:

https://lore.kernel.org/all/20230711070712.2064144-1-sanpeqf@gmail.com

\
 
 \ /
  Last update: 2023-07-11 09:10    [W:0.058 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site