Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 11 Jul 2023 15:38:18 -0700 | Subject | Re: [PATCH v3 2/3] dt-bindings: usb: snps,dwc3: Add allow-rtsusp-on-u3 property | From | Elson Serrao <> |
| |
On 7/11/2023 2:56 PM, Thinh Nguyen wrote: > On Tue, Jul 11, 2023, Elson Roy Serrao wrote: >> This property allows dwc3 runtime suspend when bus suspend interrupt >> is received even with cable connected. This would allow the dwc3 >> controller to enter low power mode during bus suspend scenario. >> >> This property would particularly benefit dwc3 IPs where hibernation is >> not enabled and the dwc3 low power mode entry/exit is handled by the >> glue driver. The assumption here is that the platform using this dt >> property is capable of detecting resume events to bring the controller >> out of suspend. >> >> Signed-off-by: Elson Roy Serrao <quic_eserrao@quicinc.com> >> --- >> Documentation/devicetree/bindings/usb/snps,dwc3.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> index a696f23730d3..18ad99a26dd9 100644 >> --- a/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> +++ b/Documentation/devicetree/bindings/usb/snps,dwc3.yaml >> @@ -403,6 +403,11 @@ properties: >> description: >> Enable USB remote wakeup. >> >> + snps,allow-rtsusp-on-u3: > > Please spell out the whole thing as "rtsusp" isn't clear. Also, it's not > just for U3 right? For highspeed, it's L2. > > How about the name that Roger use: "snps,gadget-keep-connect-sys-sleep" > Done. Will make that modification and upload v4
>> + description: >> + If True then dwc3 runtime suspend is allowed during bus suspend >> + case even with the USB cable connected. >> + >> unevaluatedProperties: false >> >> required: >> -- >> 2.17.1 >> > > Did you Cc Rob, the devicetree maintainer? >
My bad. Thanks for pointing this out
| ![\](/images/icornerr.gif) |