Messages in this thread | ![/](/images/icornerl.gif) | | Date | Tue, 11 Jul 2023 16:58:19 -0400 | From | William Breathitt Gray <> | Subject | Re: [RESEND] gpio: ws16c48: Fix off-by-one error in WS16C48 resource region extent |
| |
On Mon, Jun 05, 2023 at 09:44:38AM -0400, William Breathitt Gray wrote: > On Wed, Apr 05, 2023 at 10:47:18AM -0400, William Breathitt Gray wrote: > > On Mon, Mar 06, 2023 at 07:41:09AM -0500, William Breathitt Gray wrote: > > > On Mon, Mar 06, 2023 at 10:23:30AM +0100, Bartosz Golaszewski wrote: > > > > On Thu, Mar 2, 2023 at 11:30 PM William Breathitt Gray > > > > <william.gray@linaro.org> wrote: > > > > > > > > > > The WinSystems WS16C48 I/O address region spans offsets 0x0 through 0xA, > > > > > which is a total of 11 bytes. Fix the WS16C48_EXTENT define to the > > > > > correct value of 11 so that access to necessary device registers is > > > > > properly requested in the ws16c48_probe() callback by the > > > > > devm_request_region() function call. > > > > > > > > > > Fixes: 2c05a0f29f41 ("gpio: ws16c48: Implement and utilize register structures") > > > > > Cc: stable@vger.kernel.org > > > > > Cc: Paul Demetrotion <pdemetrotion@winsystems.com> > > > > > Signed-off-by: William Breathitt Gray <william.gray@linaro.org> > > > > > --- > > > > > > > > Why did you need to resend this? Anything changed? > > > > > > > > Bart > > > > > > No changes in code, just added the stable@ver.kernel.org Cc tag. > > > > > > William Breathitt Gray > > > > Hi Bart, > > > > Would you take this fix through the gpio tree? > > > > William Breathitt Gray > > It looks like this patch was missed. Is there anything further needed or > can it be queued as it is now? > > William Breathitt Gray
The fix was missed again this past cycle. Are there any particular issues with merging this patch that I should address? WS16C48 interrupt handling is still broken so that's the motivation for getting this fix into the GPIO tree.
William Breathitt Gray [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |