lkml.org 
[lkml]   [2023]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 2/3] dt-bindings: power: Add compatible for sdx75
From
On 11/07/2023 08:20, Rohit Agarwal wrote:
>
> On 7/11/2023 11:25 AM, Krzysztof Kozlowski wrote:
>> On 11/07/2023 07:53, Krzysztof Kozlowski wrote:
>>> On 11/07/2023 07:42, Rohit Agarwal wrote:
>>>> Add a compatible string that can be used to list PDs for sdx75.
>>>>
>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
>>>> ---
>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>>
>> Ah, I forgot: you miss device name in subject prefixes. You do not add
>> here sdx75 to all power bindings, do you? This applies to all your
>> patches and commits.
> Do you mean I need to update the subject as this?
>
> dt-bindings: power: sdx75: Add compatible for sdx75

No, the device binding is qcom,rpmpd.

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2023-07-11 08:23    [W:0.036 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site