lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] regmap: spi: Use spi_message_init_with_transfers()
On Mon, Jul 10, 2023 at 03:38:55PM +0100, Mark Brown wrote:
> On Mon, Jul 10, 2023 at 05:23:35PM +0300, Andy Shevchenko wrote:

...

> > - spi_message_init(&async->m);
> > - spi_message_add_tail(&async->t[0], &async->m);
> > - if (val)
> > - spi_message_add_tail(&async->t[1], &async->m);
> > + spi_message_init_with_transfers(&async->m, async->t, val ? 2 : 1);
>
> I'm not sure this is a legibility win.

Fair enough. Since it's not an inlined call, ion x86_64 it gives +64 bytes
to the code.

Let's drop it.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2023-07-10 17:03    [W:0.046 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site