Messages in this thread | | | Date | Mon, 10 Jul 2023 18:01:47 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 1/1] regmap: spi: Use spi_message_init_with_transfers() |
| |
On Mon, Jul 10, 2023 at 03:38:55PM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 05:23:35PM +0300, Andy Shevchenko wrote:
...
> > - spi_message_init(&async->m); > > - spi_message_add_tail(&async->t[0], &async->m); > > - if (val) > > - spi_message_add_tail(&async->t[1], &async->m); > > + spi_message_init_with_transfers(&async->m, async->t, val ? 2 : 1); > > I'm not sure this is a legibility win.
Fair enough. Since it's not an inlined call, ion x86_64 it gives +64 bytes to the code.
Let's drop it.
-- With Best Regards, Andy Shevchenko
| |