Messages in this thread | | | From | 贺中坤 <> | Date | Mon, 10 Jul 2023 22:59:18 +0800 | Subject | Re: [External] Re: [RFC PATCH 2/2] zram: charge the compressed RAM to the page's memcgroup |
| |
> > AFAICS your obj_cgroup_charge_zram doesn't have gfp argument. > > Anyway, memalloc_noreclaim_save is an abuse IMHO (the primary purpose of > the flag is to prevent recursion into the memory reclaim). Do you really > can not perform any memory recalim to trigger to free up some memory if > the memcg is at the hard limit boundary? >
Got it . I agree, memalloc_noreclaim_save should not be used, but return nomem directly,which is more clear and satisfies both direct and indirect usage.
| |