| From | Miguel Ojeda <> | Date | Mon, 10 Jul 2023 16:24:12 +0200 | Subject | Re: [PATCH 09/17] auxdisplay: Remove flag FBINFO_FLAG_DEFAULT from fbdev drivers |
| |
On Mon, Jul 10, 2023 at 3:01 PM Thomas Zimmermann <tzimmermann@suse.de> wrote: > > The flag FBINFO_FLAG_DEFAULT is 0 and has no effect, as struct > fbinfo.flags has been allocated to zero by framebuffer_alloc(). So do > not set it.
`framebuffer_alloc()` does indeed use `kzalloc()`, but the docs do not mention the zeroing. Should that guarantee be documented?
> Flags should signal differences from the default values. After cleaning > up all occurences of FBINFO_FLAG_DEFAULT, the token can be removed.
occurences -> occurrences
can -> will maybe? Since the intention of the patch series is to remove it (them) altogether).
Thanks!
Cheers, Miguel
|