lkml.org 
[lkml]   [2023]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 08/17] arch/sh: Do not assign FBINFO_FLAG_DEFAULT to fb_videomode.flag
    From
    Hi

    Am 10.07.23 um 15:59 schrieb John Paul Adrian Glaubitz:
    > Hi Thomas!
    >
    > On Mon, 2023-07-10 at 15:52 +0200, Thomas Zimmermann wrote:
    >>> I would argue that the current code is more readable that your proposed change.
    >>>
    >>> I agree that it's a no-op, but code is not just about functionality but also
    >>> readability, isn't it?
    >>
    >> I won't argue with that, but the flag itself is wrong.
    >> FBINFO_FLAG_DEFAULT is/was for struct fb_info.flags. You have struct
    >> fb_videomode.flag. The valid flags for this field are at [1]. If
    >> anything, the field could be initialized to FB_MODE_IS_UNKNOWN, which
    >> has the same value.
    >>
    >> [1] https://elixir.bootlin.com/linux/latest/source/include/linux/fb.h#L681
    >
    > FB_MODE_IS_UNKNOWN sounds very reasonable to me. Would you agree using that instead?

    Sure, I'll update the patch accordingly.

    Best regards
    Thomas

    >
    >>>
    >>> Also, I prefer "sh:" as the architecture prefix, not "arch/sh:".
    >>
    >> Ok.
    >
    > Thanks.
    >
    > Adrian
    >

    --
    Thomas Zimmermann
    Graphics Driver Developer
    SUSE Software Solutions Germany GmbH
    Frankenstrasse 146, 90461 Nuernberg, Germany
    GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
    HRB 36809 (AG Nuernberg)
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-07-10 16:05    [W:3.262 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site