Messages in this thread | | | Date | Mon, 10 Jul 2023 14:08:00 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 4/8] spi: Get rid of old SPI_MASTER_NO_.X and SPI_MASTER_MUST_.X |
| |
On Mon, Jul 10, 2023 at 12:04:35PM +0100, Mark Brown wrote: > On Mon, Jul 10, 2023 at 01:27:47PM +0300, Andy Shevchenko wrote: > > > Convert the users to SPI_CONTROLLER_NO_?X and SPI_CONTROLLER_MUST_.X > > and kill the not used anymore definitions. > > The above is not what this change does:
How to improve it? I was sure that the form of "converting to something and something" is clear...
> > - controller->flags = SPI_MASTER_MUST_RX | SPI_MASTER_MUST_TX; > > + controller->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX;
-- With Best Regards, Andy Shevchenko
| |