Messages in this thread | | | From | Benjamin Tissoires <> | Subject | Re: [PATCH HID v1] HID: nvidia-shield: Pack inner/related declarations in HOSTCMD reports | Date | Mon, 10 Jul 2023 10:32:44 +0200 |
| |
On Tue, 04 Jul 2023 23:04:14 -0700, Rahul Rameshbabu wrote: > Match alignment information in composite type declarations used by packed > HOSTCMD report structures. Compiler packing attribute is not recursive for > inner declarations. Mismatched alignment information can cause undefined > behavior in code generated for accessing composite type members. struct > pointers passed to thunderstrike_parse_board_info_payload and > thunderstrike_parse_haptics_payload are an example of this being > potentially problematic since alignment information from the packed HOSTCMD > report is lost. > > [...]
Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.5/upstream-fixes), thanks!
[1/1] HID: nvidia-shield: Pack inner/related declarations in HOSTCMD reports https://git.kernel.org/hid/hid/c/8bcf314b92ed
Cheers, -- Benjamin Tissoires <bentiss@kernel.org>
| |