Messages in this thread | | | Date | Mon, 10 Jul 2023 12:33:08 -0700 | From | Luis Chamberlain <> | Subject | Re: [PATCH v2 3/3] dyndbg: add source filename to prefix |
| |
On Sun, Jul 09, 2023 at 11:18:00PM +0200, Thomas Weißschuh wrote: > Printing the line number without the file is of limited usefulness. > > Knowing the filename also makes it also easier to relate the logged > information to the controlfile. > > Example: > > # modprobe test_dynamic_debug > # echo 'file test_dynamic_debug.c =pfsl' > /proc/dynamic_debug/control > # echo 1 > /sys/module/test_dynamic_debug/parameters/do_prints > # dmesg | tail -2 > [ 71.802212] do_cats:lib/test_dynamic_debug.c:103: test_dd: doing categories > [ 71.802227] do_levels:lib/test_dynamic_debug.c:123: test_dd: doing levels > > Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> > Acked-by: Jim Cromie <jim.cromie@gmail.com> > Acked-by: Jason Baron <jbaron@akamai.com>
Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
Luis
| |