Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 10 Jul 2023 21:15:50 +0200 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] pwm: atmel: enable clk when pwm already enabled in bootloader |
| |
Hello,
On Mon, Jul 10, 2023 at 05:00:45PM +0200, Thierry Reding wrote: > On Mon, Jul 10, 2023 at 10:42:14PM +0800, Guiting Shen wrote: > > + err = clk_enable(atmel_pwm->clk); > > + if (err) { > > + dev_err(atmel_pwm->chip.dev, "enable clock error\n"); > > Might be worth to include the error code in the error message to make it > easier to diagnose where the issue is. Something like: > > dev_err(atmel_pwm->chip.dev, "failed to enable clock: %d\n", err);
Or (IMHO) still better:
dev_err(atmel_pwm->chip.dev, "failed to enable clock: %pe\n", ERR_PTR(err));
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |