Messages in this thread | | | Date | Mon, 10 Jul 2023 09:50:28 -0600 | Subject | Re: [PATCH 1/1] net: gro: fix misuse of CB in udp socket lookup | From | David Ahern <> |
| |
On 7/10/23 8:58 AM, Richard Gobert wrote: >> put your cover letter details in here; no need for a cover letter for a >> single patch. > > I believe some details are irrelevant to the bugfix itself, > I prefer to avoid overloading the commit message... > Do you think there is a specific part of the cover letter that > should be added to the commit message? > >> there are existing iif and sdif lookup functions. I believe this gro >> path needs a different version, but it should have a comment of when it >> can be used vs the existing ones. Also, it is small enough to be an >> inline like the existing ones. e.g., see inet_sdif > > I was under the impression the coding style of Linux does not > encourage placing the inline keyword. > In which cases do you think I should add it?
See the existing *_sdif helpers in include/net/ip.h, include/linux/ipv6.h and include/net/tcp.h.
| |