Messages in this thread | | | Date | Wed, 7 Jun 2023 15:18:37 +0000 | Subject | Re: [PATCH v2 1/8] rust: workqueue: add low-level workqueue bindings | From | Alice Ryhl <> |
| |
Boqun Feng <boqun.feng@gmail.com> writes: > On Thu, Jun 01, 2023 at 01:49:39PM +0000, Alice Ryhl wrote: > [...] >> +/// A raw work item. >> +/// >> +/// This is the low-level trait that is designed for being as general as possible. >> +/// >> +/// The `ID` parameter to this trait exists so that a single type can provide multiple >> +/// implementations of this trait. For example, if a struct has multiple `work_struct` fields, then >> +/// you will implement this trait once for each field, using a different id for each field. The >> +/// actual value of the id is not important as long as you use different ids for different fields >> +/// of the same struct. (Fields of different structs need not use different ids.) >> +/// >> +/// Note that the id is used only to select the right method to call during compilation. It wont be >> +/// part of the final executable. >> +/// >> +/// # Safety >> +/// >> +/// Implementers must ensure that any pointers passed to a `queue_work_on` closure by `__enqueue` >> +/// remain valid for the duration specified in the documentation for `__enqueue`. > > ^ better to say "the #Guarantees section in the documentation for > `__enqueue`"? > > Regards, > Boqun
Sure, I will clarify that this refers to the guarantees section in the next version of the patchset.
Alice
| |