Messages in this thread | | | Date | Mon, 5 Jun 2023 08:24:00 +0200 | Subject | Re: [PATCH v2 2/3] dt-bindings: iio: adc: Add Allwinner D1/T113s/R329/T507 SoCs GPADC | From | Krzysztof Kozlowski <> |
| |
On 04/06/2023 22:20, Maxim Kiselev wrote: > пт, 2 июн. 2023 г. в 11:38, Krzysztof Kozlowski > <krzysztof.kozlowski@linaro.org>: > Hi Krzysztof, >> >> On 02/06/2023 00:30, Maksim Kiselev wrote: >>> From: Maxim Kiselev <bigunclemax@gmail.com> >>> >>> Allwinner's D1/T113s/R329/T507 SoCs have a new general purpose ADC. >>> This ADC is the same for all of this SoCs. The only difference is >>> the number of available channels. >> >> Except that it wasn't tested... > > Yes, you are right. I tested it only on the T113s board. And I will be glad if > someone tests it on another SoC.
Please show me the commands how you tested bindings on T113s board. I really would like to see them...
> > ... > >> Please run scripts/checkpatch.pl and fix reported warnings. Some >> warnings can be ignored, but the code here looks like it needs a fix. >> Feel free to get in touch if the warning is not clear. > > I got a warning about required maintainer property. Should I do > anything with this?
You should do something because sending broken code is not correct.
> If yes, then who should be a maintainer?
Someone responsible for this hardware.
> > ... > >> Hm? So you do not allow anything from adc.yaml related? Are you sure >> this is your intention? > > I'm not sure about it. I looked at other ADC bindings and didn't find > another driver with 'additionalProperties: true'
I didn't write about additionalProperties:true, but about missing ref to adc.yaml.
Best regards, Krzysztof
| |